Add tracing support using Micrometer #1695
Draft
+1,624
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozza
reviewed
May 1, 2025
There was a problem hiding this comment.
I'm liking the approach.
Does this meet the spec for transactions and retryable operations?
I'm hoping so as both OperationContext#withSessionContext and OperationContext#withTimeoutContext reuse the operation id.
However, it would be worth clarifying before reviewing further.
| import com.mongodb.internal.tracing.TraceContext; | ||
|
|
||
| public class MicrometerTracer implements Tracer { | ||
| private final io.micrometer.tracing.Tracer tracer; |
There was a problem hiding this comment.
I believe these can be imported and you don't need to use full path names. Even though this dependency is optional, it will be there at compile time (and in testing) so would only be an issue if a user tried to import the class without taking the dependency.
- Modifying UnifiedTest runner to support collecting Micrometer spans
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/JAVA-5733